feat(app): add support for pinyin layout candidates in ODD keyboard #16873
+84
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix EXEC-885
Overview
This PR adds support for a pinyin keyboard on the ODD and ensures the language update modal doesn't automatically open on desktop unless the user's system language has changed to one that we support
Test Plan and Hands on Testing
With the
enableLocalization
feature flag on:Changelog
simple-keyboard-layouts
as a dependency and pass the pinyin layout object toFullKeyboard
andAlphanumeric
keyboard if the app language is Chinese. Add some styling for this, with 60x60 keys and enough width to show all of themReview requests
Look over code, test this out if you can
Risk assessment
Low